[pubcookie-dev] Re: CVS update: jjminer; webiso/pubcookie/src mod_pubcookie.c,1.200,1.201

[Jon Miner]

Brad and I ran across this in an effort to debug a problem our new
portal was having..  We don't think this actually caused any problems,
but we did notice that on the redirect pages that these headers weren't
being set, and they presumably should..

There was actually a note at the end of login_reply_handler that
specifically mentioned that fact when it sets the cookie.

jon

* Jon Miner (miner at doit.wisc.edu) [060608 16:54]:
> Update of /usr/local/cvsroot/webiso/pubcookie/src
>  In directory webiso-cvs.cac.washington.edu:/var/tmp/cvs-serv11087
>  
>  Modified Files:
>  	mod_pubcookie.c 
>  Log Message:
>      Setting Expires, Cache-Control and Pragma via the Error headers since the
>      error headers are used on a redirect.
>  
> 
> 
> 
> Index: webiso/pubcookie/src/mod_pubcookie.c
> diff -u webiso/pubcookie/src/mod_pubcookie.c:1.200 webiso/pubcookie/src/mod_pubcookie.c:1.201
> --- webiso/pubcookie/src/mod_pubcookie.c:1.200	Fri May 19 08:57:20 2006
> +++ webiso/pubcookie/src/mod_pubcookie.c	Thu Jun  8 14:54:33 2006
> @@ -18,7 +18,7 @@
>  /** @file mod_pubcookie.c
>   * Apache pubcookie module
>   *
> - * $Id: mod_pubcookie.c,v 1.200 2006/05/19 15:57:20 jjminer Exp $
> + * $Id: mod_pubcookie.c,v 1.201 2006/06/08 21:54:33 jjminer Exp $
>   */
>  
>  #define MAX_POST_DATA 10485760
> @@ -510,14 +510,21 @@
>      char *datestr = apr_palloc (p, APR_RFC822_DATE_LEN);
>      apr_rfc822_date (datestr, r->request_time);
>      ap_table_set (r->headers_out, "Expires", datestr);
> +    ap_table_set (r->err_headers_out, "Expires", datestr);
>  #else
>      ap_table_set (r->headers_out, "Expires", ap_gm_timestr_822 (r->pool,
>                                                                  r->
>                                                                  request_time));
> +    ap_table_set (r->err_headers_out, "Expires", ap_gm_timestr_822 (r->pool,
> +                                                                r->
> +                                                                request_time));
>  #endif
>      ap_table_set (r->headers_out, "Cache-Control",
>                    "no-store, no-cache, must-revalidate");
> +    ap_table_set (r->err_headers_out, "Cache-Control",
> +                  "no-store, no-cache, must-revalidate");
>      ap_table_set (r->headers_out, "Pragma", "no-cache");
> +    ap_table_set (r->err_headers_out, "Pragma", "no-cache");
>  
>  }
>  
> 
> 
> 
> end of message
> _______________________________________________
> pubcookie-dev mailing list
> pubcookie-dev at u.washington.edu
> http://mailman1.u.washington.edu/mailman/listinfo/pubcookie-dev

-- 
.Jonathan J. Miner------------------Division of Information Technology.
|miner at doit.wisc.edu                 University Of Wisconsin - Madison|
|608/262.9655                               Room 3146 Computer Science|
`---------------------------------------------------------------------'

Look, just gimme some inner peace, or I'll mop the floor with ya!
        -- Homer Simpson
           El Viaje Misterioso de Nuestro Homer
                                                             (581/721)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 2132 bytes
Desc: not available
Url : http://mailman1.u.washington.edu/pipermail/pubcookie-dev/attachments/20060608/623c3316/smime.bin